We’re talking about organizing and maps! Join us on Open Call on May 11 to kick-off this topic and then every Tuesday through June. Click here for call-in details!

Public Lab Research note

GSoC '19: Mapknitter Rails upgrade, Phase II

by kaustubh_nair | July 21, 2019 18:32 21 Jul 18:32 | #20224 | #20224

For GSoC 19, here's my update for Phase 2 of the project Mapknitter Rails upgrade. The work as been going amazing and we are quite ahead of schedule!

Rails 5

The Rails 5 upgrade is finished completely. We've fixed all known bugs and it works perfectly locally. But we're facing some issues with asset loading on unstable, possibly due to Jenkins. Alax is looking into this issue at the moment. Hopefully this should be fixed soon and we can deploy Rails 5 to the live site!

My commits to the upgrade can be found here: https://github.com/publiclab/mapknitter/pull/685/commits

Rails 6

The Rails 6 upgrade is almost finished. We've made the configuration changes, fixed all the tests, and got it passing on Travis :) We're looking at making some enhancements such as replacing sprockets with webpacker. We're testing Rails 5 on unstable right now, so once it is ready and deployed, Rails 6 should follow along pretty soon.

Link to PR: https://github.com/publiclab/mapknitter/pull/824


I've helped set up Codecov on plots2 ( https://github.com/publiclab/plots2/pull/5954). Also we're facing some inconsistencies on Codecov reporting on Mapknitter. The test coverage for some files unexpectedly drop to zero, even though no changes were made to those files. I've spent more than a week trying all kinds of fixes, but to no avail :/ I think this is being caused due to splitting of tests on Travis, because of which Codecov is not merging the split reports properly. We might dig around a little bit more, but I noticed a few other open source repos facing the same issue. I'm thinking of contacting Codecov support and letting them know about the issue if we don't find a solution on this.

Link to issue: https://github.com/publiclab/mapknitter/issues/810

Link to PRs: https://github.com/publiclab/mapknitter/pull/837 , https://github.com/publiclab/mapknitter/pull/830 , https://github.com/publiclab/mapknitter/pull/749

Following up on Phase 1 feedback

We have been carefully recording the changes we've made on the upgrades. Once Rails 5 is ready to be published, we'll be releasing a detailed changelog highlighting all the cool new features we've introduced in Rails 5, Jenkins and Travis for the community to have a look.

Thanks! :')



hi @warren I think we'll be done with the major parts of Rails 6 in the next couple of weeks. Do you think we should upgrade spectral workbench after that?

Is this a question? Click here to post it to the Questions page.

That would be so cool. It could certainly use some work!

Reply to this comment...

Oh and there's also system tests that we can configure on mapknitter once Rails 5 is published

Love this idea. That'll help us also assess some of the Dependabot PRs which are piling up because some take manual testing.

Reply to this comment...

This is gr8 Kaustubh. Let's goooo

Reply to this comment...

Login to comment.